Comments on: Winter 2.0.1 and Winter manual updated

By: Graham Lawlor

Graham Lawlor — Mon, 13 Aug 2007 03:46:37 +0000

Hi - I just tried the workaround and the update (2.0.2) - both appear to work just as advertized. Thanks much for the quick fix!

By: swiftlytilting

swiftlytilting — Sun, 12 Aug 2007 09:56:00 +0000

Hi Graham,

I’ve solved the issue. I will release another version shortly. In the meantime you can change these lines to solve the problem:

Line 1643:
$ret = call_user_func($functionString[1],&$arr);
to
$ret = $functionString[1]($arr);

Line 1658
$ret = call_user_func($functionString[1],&$arr, $flag);
to
$ret = $functionString[1]($arr, $flag);

Thanks again for the bug report and please let me know if you experience any more problems. Also feel free to share any other comments you might have about Winter overall.

By: swiftlytilting

swiftlytilting — Sun, 12 Aug 2007 07:23:59 +0000

Hi Graham,

Thanks for the heads up.. I will look into it further but I suspect if you remove the & before $arr on line 1658 the error message will go away.

edit: Well I’ve looked into it more but I can’t seem to reproduce your error message. A very similar call occurs on line 1643 so I don’t understand why that particular line would give an error message and in fact the call won’t work unless the code is like that.

edit again: I did a little more research and it seems the default setting for allow_call_time_pass_reference is on, though the “recommended” setting is to have it disabled. Unfortunately is it needed for the code, though I will see if I can accomplish it another way.

By: Graham Lawlor

Graham Lawlor — Sun, 12 Aug 2007 06:00:56 +0000

I just installed Winter 2.0.1 on MediaWiki 1.10.0 with PHP 5.2.2. I did nothing other than place Winter.php in the Place Winter.php extensions directory and add ‘require_once(”extensions/Winter.php”);’ to the bottom of LocalSettings.php (similar to many other extensions I have installed). I started getting the error following error on all pages on my site immeditely after installing Winter:

Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of call_user_func(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. in /…./extensions/Winter.php on line 1658

I’m very new to PHP but the documentation on my web host’s site seems to incdicate that I can change this setting (allow_call_time_pass_reference) but am advised not to (ie to change the offending PHP instead). Did I install something wrong? Does this PHP setting normally have to be changed when using Winter? Is this indicative of some other problem? Possibly a conflict with another extension I have installed already?

Any help would be greatly appreciated!

Graham.